build: upgrade to go 1.19 (ethereum#25726)

This changes the CI / release builds to use the latest Go version. It also upgrades golangci-lint to a newer version compatible with Go 1.19. In Go 1.19, godoc has gained official support for links and lists. The syntax for code blocks in doc comments has changed and now requires a leading tab character. gofmt adapts comments to the new syntax automatically, so there are a lot of comment re-formatting changes in this PR. We need to apply the new format in order to pass the CI lint stage with Go 1.19. With the linter upgrade, I have decided to disable 'gosec' - it produces too many false-positive warnings. The 'deadcode' and 'varcheck' linters have also been removed because golangci-lint warns about them being unmaintained. 'unused' provides similar coverage and we already have it enabled, so we don't lose much with this change.
blakehhuynh · Oct 3, 2022 · 2ca31a1 · 2ca31a1
1 parent cd902b4
commit 2ca31a1
Show file tree

Hide file tree

Showing 107 changed files with 998 additions and 974 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -12,22 +12,19 @@ run:
 linters:
  disable-all: true
  enable:
- - deadcode
  - goconst
  - goimports
  - gosimple
  - govet
  - ineffassign
  - misspell
  - unconvert
- - varcheck
  - typecheck
  - unused
  - staticcheck
  - bidichk
  - durationcheck
  - exportloopref
- - gosec
  - whitespace
 
  # - structcheck # lots of false positives
@@ -45,11 +42,6 @@ linters-settings:
  goconst:
  min-len: 3 # minimum length of string constant
  min-occurrences: 6 # minimum number of occurrences
- gosec:
- excludes:
- - G404 # Use of weak random number generator - lots of FP
- - G107 # Potential http request -- those are intentional
- - G306 # G306: Expect WriteFile permissions to be 0600 or less
 
 issues:
  exclude-rules:
@@ -58,16 +50,15 @@ issues:
  - deadcode
  - staticcheck
  - path: internal/build/pgp.go
- text: 'SA1019: package golang.org/x/crypto/openpgp is deprecated'
+ text: 'SA1019: "golang.org/x/crypto/openpgp" is deprecated: this package is unmaintained except for security fixes.'
  - path: core/vm/contracts.go
- text: 'SA1019: package golang.org/x/crypto/ripemd160 is deprecated'
+ text: 'SA1019: "golang.org/x/crypto/ripemd160" is deprecated: RIPEMD-160 is a legacy hash and should not be used for new applications.'
  - path: accounts/usbwallet/trezor.go
- text: 'SA1019: package github.com/golang/protobuf/proto is deprecated'
+ text: 'SA1019: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.'
  - path: accounts/usbwallet/trezor/
- text: 'SA1019: package github.com/golang/protobuf/proto is deprecated'
+ text: 'SA1019: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead.'
  exclude:
  - 'SA1019: event.TypeMux is deprecated: use Feed'
  - 'SA1019: strings.Title is deprecated'
  - 'SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead.'
  - 'SA1029: should not use built-in type string as key for value'
- - 'G306: Expect WriteFile permissions to be 0600 or less'
diff --git a/.travis.yml b/.travis.yml
@@ -16,7 +16,7 @@ jobs:
  - stage: lint
  os: linux
  dist: bionic
- go: 1.18.x
+ go: 1.19.x
  env:
  - lint
  git:
@@ -31,7 +31,7 @@ jobs:
  os: linux
  arch: amd64
  dist: bionic
- go: 1.18.x
+ go: 1.19.x
  env:
  - docker
  services:
@@ -48,7 +48,7 @@ jobs:
  os: linux
  arch: arm64
  dist: bionic
- go: 1.18.x
+ go: 1.19.x
  env:
  - docker
  services:
@@ -65,7 +65,7 @@ jobs:
  if: type = push
  os: linux
  dist: bionic
- go: 1.18.x
+ go: 1.19.x
  env:
  - ubuntu-ppa
  - GO111MODULE=on
@@ -90,7 +90,7 @@ jobs:
  os: linux
  dist: bionic
  sudo: required
- go: 1.18.x
+ go: 1.19.x
  env:
  - azure-linux
  - GO111MODULE=on
@@ -162,7 +162,7 @@ jobs:
  - stage: build
  if: type = push
  os: osx
- go: 1.18.x
+ go: 1.19.x
  env:
  - azure-osx
  - azure-ios
@@ -194,7 +194,7 @@ jobs:
  os: linux
  arch: amd64
  dist: bionic
- go: 1.18.x
+ go: 1.19.x
  env:
  - GO111MODULE=on
  script:
@@ -214,7 +214,7 @@ jobs:
  - stage: build
  os: linux
  dist: bionic
- go: 1.17.x
+ go: 1.18.x
  env:
  - GO111MODULE=on
  script:
@@ -225,7 +225,7 @@ jobs:
  if: type = cron
  os: linux
  dist: bionic
- go: 1.18.x
+ go: 1.19.x
  env:
  - azure-purge
  - GO111MODULE=on
@@ -239,7 +239,7 @@ jobs:
  if: type = cron
  os: linux
  dist: bionic
- go: 1.18.x
+ go: 1.19.x
  env:
  - GO111MODULE=on
  script:

diff --git a/accounts/abi/abi_test.go b/accounts/abi/abi_test.go
@@ -165,8 +165,9 @@ func TestInvalidABI(t *testing.T) {
 
 // TestConstructor tests a constructor function.
 // The test is based on the following contract:
-// contract TestConstructor {
-// constructor(uint256 a, uint256 b) public{}
+//
+// contract TestConstructor {
+// constructor(uint256 a, uint256 b) public{}
 // }
 func TestConstructor(t *testing.T) {
  json := `[{ "inputs": [{"internalType": "uint256","name": "a","type": "uint256" },{ "internalType": "uint256","name": "b","type": "uint256"}],"stateMutability": "nonpayable","type": "constructor"}]`
@@ -724,16 +725,19 @@ func TestBareEvents(t *testing.T) {
 }
 
 // TestUnpackEvent is based on this contract:
-// contract T {
-// event received(address sender, uint amount, bytes memo);
-// event receivedAddr(address sender);
-// function receive(bytes memo) external payable {
-// received(msg.sender, msg.value, memo);
-// receivedAddr(msg.sender);
-// }
-// }
+//
+// contract T {
+// event received(address sender, uint amount, bytes memo);
+// event receivedAddr(address sender);
+// function receive(bytes memo) external payable {
+// received(msg.sender, msg.value, memo);
+// receivedAddr(msg.sender);
+// }
+// }
+//
 // When receive("X") is called with sender 0x00... and value 1, it produces this tx receipt:
-// receipt{status=1 cgas=23949 bloom=00000000004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000040200000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 logs=[log: b6818c8064f645cd82d99b59a1a267d6d61117ef [75fd880d39c1daf53b6547ab6cb59451fc6452d27caa90e5b6649dd8293b9eed] 000000000000000000000000376c47978271565f56deb45495afa69e59c16ab200000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000158 9ae378b6d4409eada347a5dc0c180f186cb62dc68fcc0f043425eb917335aa28 0 95d429d309bb9d753954195fe2d69bd140b4ae731b9b5b605c34323de162cf00 0]}
+//
+// receipt{status=1 cgas=23949 bloom=00000000004000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000040200000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 logs=[log: b6818c8064f645cd82d99b59a1a267d6d61117ef [75fd880d39c1daf53b6547ab6cb59451fc6452d27caa90e5b6649dd8293b9eed] 000000000000000000000000376c47978271565f56deb45495afa69e59c16ab200000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000000158 9ae378b6d4409eada347a5dc0c180f186cb62dc68fcc0f043425eb917335aa28 0 95d429d309bb9d753954195fe2d69bd140b4ae731b9b5b605c34323de162cf00 0]}
 func TestUnpackEvent(t *testing.T) {
  const abiJSON = `[{"constant":false,"inputs":[{"name":"memo","type":"bytes"}],"name":"receive","outputs":[],"payable":true,"stateMutability":"payable","type":"function"},{"anonymous":false,"inputs":[{"indexed":false,"name":"sender","type":"address"},{"indexed":false,"name":"amount","type":"uint256"},{"indexed":false,"name":"memo","type":"bytes"}],"name":"received","type":"event"},{"anonymous":false,"inputs":[{"indexed":false,"name":"sender","type":"address"}],"name":"receivedAddr","type":"event"}]`
  abi, err := JSON(strings.NewReader(abiJSON))
@@ -1078,8 +1082,9 @@ func TestDoubleDuplicateMethodNames(t *testing.T) {
 // TestDoubleDuplicateEventNames checks that if send0 already exists, there won't be a name
 // conflict and that the second send event will be renamed send1.
 // The test runs the abi of the following contract.
-// contract DuplicateEvent {
-// event send(uint256 a);
+//
+// contract DuplicateEvent {
+// event send(uint256 a);
 // event send0();
 // event send();
 // }
@@ -1106,7 +1111,8 @@ func TestDoubleDuplicateEventNames(t *testing.T) {
 // TestUnnamedEventParam checks that an event with unnamed parameters is
 // correctly handled.
 // The test runs the abi of the following contract.
-// contract TestEvent {
+//
+// contract TestEvent {
 // event send(uint256, uint256);
 // }
 func TestUnnamedEventParam(t *testing.T) {