Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect Zod Schema Generation for Datetime Fields #4377

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

doe-base
Copy link
Contributor

@doe-base doe-base commented Sep 23, 2024

This PR fixes an issue with Zod schema generation for datetime fields by removing extra parentheses, ensuring proper validation.

closes #4376

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: e4e6621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@blitzjs/generator Patch
blitz Patch
@blitzjs/codemod Patch
next-blitz-auth Patch
@blitzjs/auth Patch
@blitzjs/next Patch
@blitzjs/rpc Patch
@blitzjs/config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@siddhsuresh siddhsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@siddhsuresh
Copy link
Member

siddhsuresh commented Sep 29, 2024

hey @doe-base would you be willing to also fix the unit test snapshot? lmk if you have any questions

@siddhsuresh siddhsuresh removed the request for review from flybayer September 29, 2024 21:14
@siddhsuresh siddhsuresh removed the 0 - <(^_^)> - merge it! ✌️ Kodiak automerge label Sep 29, 2024
@kodiakhq kodiakhq bot merged commit 56bd32b into blitz-js:main Sep 30, 2024
29 of 30 checks passed
@blitzjs-bot
Copy link
Contributor

Added @doe-base contributions for doc, code and test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Zod Schema Generation for Datetime Fields when using blitz generate
4 participants