Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi chain balance button #1912

Merged
merged 5 commits into from
May 27, 2024
Merged

Multi chain balance button #1912

merged 5 commits into from
May 27, 2024

Conversation

isstuev
Copy link
Collaborator

@isstuev isstuev commented May 14, 2024 •
edited
Loading

Description and Related Issue(s)

resolves #1802

Proposed Changes

added NEXT_PUBLIC_MULTICHAIN_PROVIDER_CONFIG variable to enable multichain balance button

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@isstuev isstuev force-pushed the fe-1802 branch 6 times, most recently from 7128ffb to e5d9d5c Compare May 16, 2024 11:14
@isstuev isstuev marked this pull request as ready for review May 16, 2024 11:30
@isstuev isstuev force-pushed the fe-1802 branch 2 times, most recently from 9c33fb4 to 7707c83 Compare May 16, 2024 13:45
@isstuev isstuev force-pushed the fe-1802 branch 2 times, most recently from 2cdc73c to 83a1f9e Compare May 17, 2024 11:53
@isstuev isstuev requested review from tom2drum and maxaleks May 20, 2024 09:59
@github-actions github-actions bot added the enhancement New feature or request label May 20, 2024
tom2drum
tom2drum reviewed May 20, 2024
View reviewed changes
configs/app/features/multichainButton.ts Outdated Show resolved Hide resolved
configs/app/features/multichainButton.ts Outdated Show resolved Hide resolved
configs/envs/.env.eth Outdated Show resolved Hide resolved
deploy/tools/envs-validator/schema.ts Outdated Show resolved Hide resolved
docs/ENVS.md Outdated Show resolved Hide resolved
ui/address/details/AddressNetWorth.pw.tsx Outdated Show resolved Hide resolved
ui/address/details/AddressNetWorth.tsx Outdated Show resolved Hide resolved
@isstuev isstuev requested a review from tom2drum May 27, 2024 10:10
@isstuev isstuev merged commit 04f051f into main May 27, 2024
12 checks passed
@isstuev isstuev deleted the fe-1802 branch May 27, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

@maxaleks maxaleks Awaiting requested review from maxaleks

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi chain balance button
2 participants
@isstuev @tom2drum