Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to change ERC to something else #1961

Merged
merged 1 commit into from
May 29, 2024
Merged

Add possibility to change ERC to something else #1961

merged 1 commit into from
May 29, 2024

Conversation

isstuev
Copy link
Collaborator

@isstuev isstuev commented May 28, 2024

Description and Related Issue(s)

resolves #1955

Proposed Changes

added NEXT_PUBLIC_NETWORK_TOKEN_STANDARD_NAME variable to configure the display name of a token creation standard

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@isstuev isstuev marked this pull request as ready for review May 28, 2024 19:43
@isstuev isstuev requested a review from tom2drum May 28, 2024 19:43
Copy link
Collaborator

@tom2drum tom2drum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding some tests to cover new functionality.

@isstuev
Copy link
Collaborator Author

isstuev commented May 29, 2024

Consider adding some tests to cover new functionality.

I don't think we need tests here, the uncovered logic is only reading env from variable. all the rest is covered because even the default ERC name now comes from the config (and we have tests with token types), not from the API directly.

@isstuev isstuev merged commit 8634bc5 into main May 29, 2024
12 checks passed
@isstuev isstuev deleted the fe-1955 branch May 29, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to change 'ERC' to something else
2 participants