Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore GraphQL API with Strawberry #139

Open
callumforrester opened this issue Aug 19, 2024 · 1 comment
Open

Restore GraphQL API with Strawberry #139

callumforrester opened this issue Aug 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@callumforrester
Copy link
Contributor

callumforrester commented Aug 19, 2024

See #134 for details.

We have decided to put the GraphQL API back, using Strawberry GraphQL instead of graphql-core, and alongside the REST API.

Acceptance Criteria

  • Running scanspec service exposes both a GraphQL and a REST API.
  • The GraphQL API has the same functionality as the legacy API in GraphQL API #134
  • The GraphQL API is based on Strawberry GraphQL
  • The GraphQL API has tests
@callumforrester callumforrester added the enhancement New feature or request label Aug 19, 2024
@callumforrester
Copy link
Contributor Author

A note: Since we are going to try and keep the old FastAPI REST API around, it makes sense to try and make use of Strawbery's FastAPI integration if we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant