Skip to content
This repository has been archived by the owner on Sep 12, 2020. It is now read-only.

STOP MAINTAINING THIS REPOSITORY #79

Closed
bbortt opened this issue Sep 10, 2020 · 1 comment · Fixed by #80
Closed

STOP MAINTAINING THIS REPOSITORY #79

bbortt opened this issue Sep 10, 2020 · 1 comment · Fixed by #80

Comments

@bbortt
Copy link
Collaborator

bbortt commented Sep 10, 2020

hi @bmealhouse

I think at this point it does not make sense to continue supporting this repository. next.js has grown massively and other packages with bedder support have covered this functionality (ssr with redux-saga) already.

from the README.md of next redux-wrapper.

Setting up Redux for static apps is rather simple: a single Redux store has to be created that is provided to all pages.
When Next.js static site generator or server side rendering is involved, however, things start to get complicated as another store instance is needed on the server to render Redux-connected components.
Furthermore, access to the Redux Store may also be needed during a page's getInitialProps.
This is where next-redux-wrapper comes in handy: It automatically creates the store instances for you and makes sure they all have the same state.
Moreover it allows to properly handle complex cases like App.getInitialProps (when using pages/_app) together with getStaticProps or getServerSideProps at individual page level.
Library provides uniform interface no matter in which Next.js lifecycle method you would like to use the Store.

if we take a look at the next.js "with-redux-saga" example, it doesn't even include next-redux-saga anymore. it is done via next-redux-wrapper and actually a duplicate of the example "with-redux-wrapper". package.json:

"dependencies": {
  "next": "latest",
  "next-redux-wrapper": "^6.0.2",
  "react": "16.13.1",
  "react-dom": "16.13.1",
  "react-redux": "7.2.0",
  "redux": "4.0.5",
  "redux-saga": "1.1.3"
},

my suggestions is as following: I will create one last PR stating out the reason this package was abandoned, next you archive it -> "read only".

@bmealhouse
Copy link
Owner

@bbortt - I agree and I'm on board with this. Thanks again for all the time and effort you've contributed to maintaining this library.

bbortt added a commit that referenced this issue Sep 11, 2020
…tained

#79 give a deprecation notice of this repository.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants