[validators] Fix marker generation for validators #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bndtools#5006 Signed-off-by: Fr Jeremy Krieg <[email protected]>
kriegfrj
force-pushed
the
5006-validators
branch
from
c7f6d15
to
fca63a7
Compare
|
LGTM. Just see that the validation happens in the MarkerSupport class is a bit strange, it never creates any markers. But I am ok |
|
Sorry, I didn't understand your comment? |
|
I looked at the code and wondered why the validation happened on the MarkerSupport class. Since it does not create markers but only errors/warnings on a processor, it is not the logical class to put this code in. I looked at this because we should not create markers inside the lock. However, been like that forever and we don't have to fix this now. |
|
I agree. In #5004 it was natural to move it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the validators are run on the model before the processor copies them into itself.
Fixes #5006