Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide embedded DLLs from the solution explorer #1894

Merged

Conversation

PathogenDavid
Copy link
Member

Another minor echo of the release automation changes.

This hides the DLLs embedded in the bootstrapper for System.Resources.Extensions and its dependencies from the solution explorer, which are unintentionally left visible before this change:

Screenshot of Visual Studio solution explorer with DLL files listed

These don't live in the project folder, and without the context of reading the csproj they're just confusing noise.

(That being said if you like being reminded that they're there we can just leave them. Could also hide them in a folder as an in-between option.)

Relates to #1873

@PathogenDavid PathogenDavid added this to the 2.8.4 milestone Jul 9, 2024
Copy link
Member

@glopesdev glopesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree in this case it makes more sense to hide them since there are a bunch of other references which are being repacked as well and do not show up.

Also hopefully we are migrating away from this in the near future so we won't need the reminder.

@glopesdev glopesdev added the fix Pull request that fixes an issue label Jul 9, 2024
@glopesdev glopesdev merged commit bff1088 into bonsai-rx:main Jul 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull request that fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants