Update docfx version and export sitemap #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
added
the
engineering
glopesdev
changed the title
PathogenDavid
approved these changes
Jul 26, 2024
|
Looks good, although it's worth pointing out that it won't (automatically) get picked up without adding it to the main website's Edit: Created bonsai-rx/bonsai-rx.github.io#3 to address this. (Merge after this one.) |
PathogenDavid
added a commit
to PathogenDavid/bonsai-rx.github.io
that referenced
this pull request
Jul 26, 2024
Before this change, robots.txt was getting automatically generated by `jekyll-sitemap` for the main sitemap, so the main entry isn't actually new. Related to bonsai-rx/docs#91 Also adds `webrick` to Gemfile, which is required to use `jekyll serve` with recent versions of Ruby as noted here: https://jekyllrb.com/docs/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new DocFX release resolves the regression with external
xrefmap.ymlfiles so we are again safe to upgrade. Following the recommendation in #90 we have also turned on exporting of thesitemap.xmlfile for more efficient crawling.