Add runtime-benchmarks feature check into CI (paritytech#793)

Signed-off-by: koushiro <[email protected]>
boolnetwork · Jul 25, 2022 · 660779b · 660779b
1 parent 9318023
commit 660779b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
@@ -79,4 +79,4 @@ jobs:
  - name: Rustfmt
  run: cargo fmt --all -- --check
  - name: Clippy
- run: cargo clippy --all -- -D warnings
+ run: cargo clippy --all --features runtime-benchmarks -- -D warnings
diff --git a/frame/evm/src/benchmarking.rs b/frame/evm/src/benchmarking.rs
@@ -106,7 +106,7 @@ benchmarks! {
 
  }: {
 
- nonce = nonce + 1;
+ nonce += 1;
  let nonce_as_u256: U256 = nonce.into();
 
  let is_transactional = true;
@@ -125,7 +125,7 @@ benchmarks! {
  validate,
  T::config(),
  );
- assert_eq!(call_runner_results.is_ok(), true, "call() failed");
+ assert!(call_runner_results.is_ok(), "call() failed");
  }
 }
 

diff --git a/frame/hotfix-sufficients/src/benchmarking.rs b/frame/hotfix-sufficients/src/benchmarking.rs
@@ -54,7 +54,7 @@ benchmarks! {
  accounts
  .iter()
  .for_each(|id| {
- assert_eq!(frame_system::Pallet::<T>::sufficients(&id), 1);
+ assert_eq!(frame_system::Pallet::<T>::sufficients(id), 1);
  });
  }
 }

diff --git a/template/runtime/src/lib.rs b/template/runtime/src/lib.rs
@@ -835,7 +835,7 @@ impl_runtime_apis! {
  list_benchmark!(list, extra, pallet_hotfix_sufficients, PalletHotfixSufficients::<Runtime>);
 
  let storage_info = AllPalletsWithSystem::storage_info();
- return (list, storage_info)
+ (list, storage_info)
  }
 
  fn dispatch_benchmark(