Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swtich to common Boost configuration for CMake with boost_gil target #463

Closed
mloskot opened this issue Mar 23, 2020 · 1 comment
Closed
Labels
cat/enhancement Improvements, but not fixes addressing identified bugs config/cmake Any issues about CMake configuration good-first-issue Opportunity for new contributors to help improving GIL
Milestone

Comments

@mloskot
Copy link
Member

mloskot commented Mar 23, 2020

We should switch to the common configuration developed by @pdimov for Boost.
It is simplest possible, working CMake for Boost based on generating bolierplate, with minimal maintenance required, which works very well, which still allows customised configuration.

References

Example

# Generated by `boostdep --cmake gil`
# Copyright 2020 Peter Dimov
# Distributed under the Boost Software License, Version 1.0.
# https://www.boost.org/LICENSE_1_0.txt
cmake_minimum_required(VERSION 3.5...3.16)
project(boost_gil VERSION "${BOOST_SUPERPROJECT_VERSION}" LANGUAGES CXX)
add_library(boost_gil INTERFACE)
add_library(Boost::gil ALIAS boost_gil)
target_include_directories(boost_gil INTERFACE include)
target_link_libraries(boost_gil
  INTERFACE
    Boost::assert
    Boost::concept_check
    Boost::config
    Boost::core
    Boost::filesystem
    Boost::integer
    Boost::iterator
    Boost::mp11
    Boost::mpl
    Boost::numeric_conversion
    Boost::preprocessor
    Boost::variant
)
if(BUILD_TESTING AND EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/test/CMakeLists.txt")
  add_subdirectory(test)
endif()
@mloskot mloskot added cat/enhancement Improvements, but not fixes addressing identified bugs config/cmake Any issues about CMake configuration labels Mar 23, 2020
@mloskot mloskot added the good-first-issue Opportunity for new contributors to help improving GIL label Dec 15, 2021
@mloskot
Copy link
Member Author

mloskot commented Sep 27, 2024

@mloskot mloskot closed this as completed Sep 27, 2024
@mloskot mloskot added this to the Boost 1.80 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/enhancement Improvements, but not fixes addressing identified bugs config/cmake Any issues about CMake configuration good-first-issue Opportunity for new contributors to help improving GIL
Projects
None yet
Development

No branches or pull requests

1 participant