Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test cases for wide character path conversions #754

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

striezel
Copy link
Contributor

@striezel striezel commented Jul 23, 2024

Description

Add test cases for the fixes made in #746 to avoid future regressions.

(This is the first time I created a test case for GIL, so it might not build and pass on first try.)

References

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@striezel
Copy link
Contributor Author

Tests passed on first try? 😮

Actually, I'm not even mad. That's amazing.

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mloskot mloskot added cat/enhancement Improvements, but not fixes addressing identified bugs ext/io boost/gil/extension/io/ test New tests development or missing tests issues, no new functionality labels Jul 23, 2024
@mloskot mloskot merged commit f56c4c6 into boostorg:develop Jul 23, 2024
18 checks passed
@striezel striezel deleted the add-path-conversion-tests branch July 23, 2024 23:19
@striezel
Copy link
Contributor Author

Now that I know how to use Boost's lightweight_test I hope to write more tests in the future. :) Especially when bugs get fixed, there should be some regression tests for the fix to avoid reintroducing a bug by accident.

@mloskot
Copy link
Member

mloskot commented Aug 1, 2024

there should be some regression tests for the fix to avoid reintroducing a bug by accident

Indeed.

We encourage PR authors to always cover features and fixes with tests, from https:/boostorg/gil/blob/develop/CONTRIBUTING.md#pull-requests

DO ensure any new features or changes to existing behaviours are covered with test cases.

IMO, tests are also a very useful source of 'expected behaviour documentation', especially when the prose documentation is lacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/enhancement Improvements, but not fixes addressing identified bugs ext/io boost/gil/extension/io/ test New tests development or missing tests issues, no new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants