Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct divide-by-zero in cpp_int modulus operations. #625

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Conversation

jzmaddock
Copy link
Collaborator

Also added some more efficient operator overloads for the trivial case. Fixes #624

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.1%. Comparing base (f9fdcc2) to head (b0ea443).

Current head b0ea443 differs from pull request most recent head 891e2c3

Please upload reports for the commit 891e2c3 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #625     +/-   ##
=========================================
+ Coverage     94.1%   94.1%   +0.1%     
=========================================
  Files          274     275      +1     
  Lines        26766   26794     +28     
=========================================
+ Hits         25161   25188     +27     
- Misses        1605    1606      +1     
Files Coverage Δ
test/git_issue_624.cpp 100.0% <100.0%> (ø)
include/boost/multiprecision/cpp_int/divide.hpp 92.5% <83.4%> (-<0.1%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fdcc2...891e2c3. Read the comment docs.

@jzmaddock jzmaddock merged commit 58b3962 into develop Jun 21, 2024
1 of 76 checks passed
@NAThompson NAThompson deleted the issue624 branch June 21, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SEGFPE on Modulus Operation with Negative Signed Numbers Greater Than 128 Bits
1 participant