cmd/scollector: continue snmp walk on row error

cmd/scollector/collectors/snmp.go

@@ -11,6 +11,7 @@ import (
  "bosun.org/cmd/scollector/conf"
  "bosun.org/metadata"
  "bosun.org/opentsdb"
+ "bosun.org/slog"
  "bosun.org/snmp"
 )
 
@@ -72,7 +73,8 @@ func snmp_subtree(host, community, oid string) (map[string]interface{}, error) {
  a = new(big.Int)
  id, err := rows.Scan(&a)
  if err != nil {
- return nil, err
+ slog.Errorf("Error scanning oid %v on host %v: %v", oid, host, err)
+ continue
  }
  switch t := id.(type) {
  case int:
@@ -83,7 +85,8 @@ func snmp_subtree(host, community, oid string) (map[string]interface{}, error) {
  default:
  id, err := rows.Scan(&a)
  if err != nil {
- return nil, err
+ slog.Errorf("Error scanning oid %v on host %v: %v", oid, host, err)
+ continue
  }
  switch t := id.(type) {
  case int:

snmp/snmp.go

@@ -29,10 +29,6 @@ func (b *binding) unmarshal(v interface{}) error {
  convertClass(&b.Value)
  _, err := asn1.Unmarshal(b.Value.FullBytes, v)
  if err != nil {
- if _, ok := err.(asn1.StructuralError); ok {
- return fmt.Errorf("type mismatch: {class:%d tag:%d} vs. %T: %v",
- b.Value.Class, b.Value.Tag, v, err)
- }
  return err
  }
  v = convertType(v)