Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/scollector: Identify the interface type via IF-MIB:ifType #1242

Merged
merged 1 commit into from
Aug 5, 2015

Conversation

kylebrandt
Copy link
Member

Instead of string parsing - mostly.

return osNet + ".virtual" + strings.TrimPrefix(metric, osNet)
case 131:
return osNet + ".tunnel" + strings.TrimPrefix(metric, osNet)
case 161:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can combine this with the 53 case by using fallthrough.

captncraig pushed a commit that referenced this pull request Aug 5, 2015
cmd/scollector: Identify the interface type via IF-MIB:ifType
@captncraig captncraig merged commit d48c611 into master Aug 5, 2015
@captncraig captncraig deleted the snmpIfType branch August 5, 2015 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants