cmd/bosun: Add normalize switch to graph page to display series on 0-… #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrandt
force-pushed
the
percentageGraph
branch
from
fa6b37d
to
e399c17
Compare
|
go generate error is a lie. |
|
Here is what it looks like:
Vs
|
…100 scale Each series is displayed on a scale of 0-100. This helps to visually see if there is apparent correlation between metrics with vastly different scales. I tried to other options, d3.power scales and d3.log scales. Power scales weere not effective for getting good correlation views. Log scales don't implement well for ad-hoc graphing. There can't be 0 values, series cannot cross the positive/negative threshold, and negative series must be handled differently.
kylebrandt
force-pushed
the
percentageGraph
branch
from
e399c17
to
5f2fd4e
Compare
|
LGTM |
|
@kylebrandt just curious, what correlates on your first screenie? green and blue? |
|
Oh nothing really, those were just metrics with varied scales
|
kylebrandt
added a commit
that referenced
this pull request
Aug 18, 2015
cmd/bosun: Add normalize switch to graph page to display series on 0-…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…100 scale
Each series is displayed on a scale of 0-100. This helps to visually see if there is apparent correlation between metrics with vastly different scales. I tried to other options, d3.power scales and d3.log scales. Power scales weere not effective for getting good correlation views. Log scales don't implement well for ad-hoc graphing. There can't be 0 values, series cannot cross the positive/negative threshold, and negative series must be handled differently.