Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/scollector: count running linux processes from linux.proc collector #1316

Merged
merged 1 commit into from
Sep 17, 2015

Conversation

d10v
Copy link
Contributor

@d10v d10v commented Sep 12, 2015

Kind of fixes #1079 . The goal is to have something to track if there are no running processes matching from [[Process]] entry and not use since().

@gbrayut
Copy link
Contributor

gbrayut commented Sep 14, 2015

We would prefer to only count processes that are registered to run or have previously been seen on a system. We use the same toml file for all hosts to simply setup, so we wouldn't want a metric indicating that our mail server process is not running on our backup servers (since it never was suppose to).

Maybe you can add an IncludeCount = true option to the Config/WatchedProc settings so that this feature is disable by default but can be enabled for specific entries. Example where it is not included for puppet-agent but is included for haproxy-t1:

[[Process]]
  Command = "ruby"
  Name = "puppet-agent"
  Args = "puppet"

[[Process]]
  Command = "/haproxy"
  Name = "haproxy-t1"
  Args = "/etc/haproxy-t1/haproxy-t1.cfg"
  IncludeCount = true

@d10v
Copy link
Contributor Author

d10v commented Sep 17, 2015

@gbrayut updated PR accordingly

@gbrayut
Copy link
Contributor

gbrayut commented Sep 17, 2015

LGTM!

gbrayut added a commit that referenced this pull request Sep 17, 2015
cmd/scollector: count running linux processes from linux.proc collector
@gbrayut gbrayut merged commit a904d34 into bosun-monitor:master Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track if a process is running or not
2 participants