metadata: fix a goroutine and memory leak in sendMetadata() #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defer close http response body in sendMetadata(). The http response body doesn't get closed after sendMetada() return, which will cause two goroutines and quite some memory leak every hour.
|
@noblehng Did you use bosun/scollector to find the leak in scollector? That would be a fun screenshot - thanks for spotting this! |
kylebrandt
added a commit
that referenced
this pull request
Nov 20, 2015
metadata: fix a goroutine and memory leak in sendMetadata()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer close http response body in sendMetadata().
The http response body doesn't get closed after sendMetada() return,
which will cause two goroutines and quite some memory leak every hour.
Scollector on our haproxy boxs got to the internal 500 MiB memory limit and
panic crashed within a week. I analyzed the crash log and graphed memory
usage and goroutine count metrics of scollector, then found out the problem.
Metrics are really great for identifying this kind of problems, and I want to say
a big thank you for your great work building bosun and scollector.