cmd/scollector: Added ExtraHop collector #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenderson-so
force-pushed
the
ExtraHop-v1
branch
from
ed9db90
to
737d64f
Compare
| return rets | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
Generally we don't merge in commented code. So this should probably be moved to another branch.
mhenderson-so
force-pushed
the
ExtraHop-v1
branch
from
737d64f
to
ad1982a
Compare
| *md = append(*md, np) | ||
| } | ||
| //And add the metadata for the metric | ||
| metadata.AddMeta(xhMetricName, nil, "rate", l7s.Rate, false) |
There was a problem hiding this comment.
Call this in an init instead of with each collector run.
mhenderson-so
force-pushed
the
ExtraHop-v1
branch
from
ad1982a
to
b2ebe5f
Compare
mhenderson-so
force-pushed
the
ExtraHop-v1
branch
from
b2ebe5f
to
678b2db
Compare
kylebrandt
added a commit
that referenced
this pull request
Dec 7, 2015
cmd/scollector: Added ExtraHop collector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtraHop collector. Right now it only collects the L7 information (bytes and packets) for all networks, broken by vlan and protocol. In the config file you can choose how you want to filter the data - by traffic count, named protocols, or no filtering.