cmd/scollector: normalize process metrics into os namespace #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return fmt.Errorf("failed to convert process user cpu: %v", err) | ||
| } | ||
| totalVirtualMem += virtual | ||
| rss, err := strconv.ParseInt(stats[23], 10, 54) |
|
Back do you, @kylebrandt |
|
@alienth Ya I considered that but my understanding is that the CPU time will be based on the number of logical cores. So maybe I should just rename it to be clear? |
|
@kylebrandt Rename sounds fine, or maybe just a description note. |
kylebrandt
force-pushed
the
serviceCPUMem
branch
from
4211b46
to
29d517a
Compare
|
🐟 lgtm |
| @@ -140,6 +145,8 @@ func c_windows_processes() (opentsdb.MultiDataPoint, error) { | |||
| tags := opentsdb.TagSet{"name": name, "id": id} | |||
| AddTS(&md, "win.proc.cpu", ts, v.PercentPrivilegedTime/NS100_Seconds/numberOfLogicalProcessors, opentsdb.TagSet{"type": "privileged"}.Merge(tags), metadata.Counter, metadata.Pct, descWinProcCPU_priv) | |||
| AddTS(&md, "win.proc.cpu", ts, v.PercentUserTime/NS100_Seconds/numberOfLogicalProcessors, opentsdb.TagSet{"type": "user"}.Merge(tags), metadata.Counter, metadata.Pct, descWinProcCPU_user) | |||
| totalCPUByName[name] += v.PercentUserTime / NS100_Seconds / numberOfLogicalProcessors | |||
| AddTS(&md, "win.proc.cpu_total", ts, v.PercentProcessorTime/NS100_Seconds/numberOfLogicalProcessors, tags, metadata.Counter, metadata.Pct, descWinProcCPU_total) | |||
| AddTS(&md, "win.proc.cpu_total", ts, v.PercentProcessorTime/NS100_Seconds/numberOfLogicalProcessors, tags, metadata.Counter, metadata.Pct, descWinProcCPU_total) | |||
There was a problem hiding this comment.
Duplicate line? or is this just a funky diff?
kylebrandt
force-pushed
the
serviceCPUMem
branch
from
29d517a
to
02c0129
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.