cmd/bosun: annotate support #1610
Conversation
|
|
| if err := annotateBackend.InitBackend(); err != nil { | ||
| return err | ||
| } | ||
| web.AddRoutes(router, "/api", []backend.Backend{annotateBackend}, false, false) |
There was a problem hiding this comment.
I like this way of doing it a lot. What are the last two bool parameters for? Mostly out of curiosity.
There was a problem hiding this comment.
are we gonna try to get the ui working at some point?
There was a problem hiding this comment.
enable the independent UI, and use local dev files when doing so
On Mon, Feb 22, 2016 at 11:56 AM, Craig Peterson [email protected]
wrote:
In cmd/bosun/web/web.go
#1610 (comment):
- // Annotations
- if schedule.Conf.AnnotateEnabled() {
var err errorindex := schedule.Conf.AnnotateIndexif index == "" {index = "annotate"}annotateBackend, err = backend.NewElastic(schedule.Conf.AnnotateElasticHosts, index)if err != nil {return err}if err := annotateBackend.InitBackend(); err != nil {return err}web.AddRoutes(router, "/api", []backend.Backend{annotateBackend}, false, false)I like this way of doing it a lot. What are the last two bool parameters
for? Mostly out of curiosity.—
Reply to this email directly or view it on GitHub
https:/bosun-monitor/bosun/pull/1610/files#r53654814.
There was a problem hiding this comment.
The UI does work, but I don't intend to just import the UI into bosun, Bosun will integrate with it using it's own UI.
There was a problem hiding this comment.
was thinking it might be nice if your ui has direct query/filter/ raw viewing support.
There was a problem hiding this comment.
Agreed, approaching this incremently and thinking of it as probably a "preview" feature when we release
|
LGTM |
No description provided.