cmd/bosun: clear filters when changing metrics in graph view #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1679, Creates #??
|
Need to test this more before merging. This code is really messy at this point. There is probably repeated operations on tags and filters that don't need to be there. Once OpenTSDB is at v2.3 we can remove support for v2.1 and at that time I think it will be easier to redo this code. |
|
There is still an edge case here where if you switch metrics, the two metrics share a tag key, but the value set for that tag is not present in the new metric it will still be there. However, in that case this isn't hidden and you can just change the value, so I don't care to fix this at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1679, Creates #??