Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bosun: support actions by incident id #1696

Merged
merged 1 commit into from
Apr 5, 2016
Merged

cmd/bosun: support actions by incident id #1696

merged 1 commit into from
Apr 5, 2016

Conversation

kylebrandt
Copy link
Member

No description provided.

if err := collect.Add("actions", opentsdb.TagSet{"user": user, "alert": ak.Name(), "type": t.String()}, 1); err != nil {
slog.Errorln(err)
}
func (s *Schedule) ActionByAlertKey(user, message string, t models.ActionType, ak models.AlertKey) (*models.IncidentState, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anyone using this return value. Is it just to maintain parity with ActionByIncidentID. Does that need to return the whole incident, or just the alert key?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I just want the alert key. Will change

@kylebrandt kylebrandt merged commit 50185c9 into master Apr 5, 2016
@kylebrandt kylebrandt deleted the actionById branch April 8, 2016 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants