cmd/scollector: skip md volumes if mdadm binary is missing #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -169,7 +169,10 @@ func examineMdadmVolume(volumeName string) (volumeDetail, error) { | |||
| // We don't use --test because it has failed us in the past. | |||
| // Maybe we should use it sometime in the future | |||
| output, err := util.Command(tmout, nil, "mdadm", "--detail", volumeName) | |||
| detail := parseExamineMdadm(output) | |||
| detail := volumeDetail{} | |||
There was a problem hiding this comment.
Just a minor thing. I'm much more used to seeing if err != nil blocks. How about:
if err != nil{
return volumeDetail{}, err
}
return parseExamineMdadm(output), nil
|
Thank you for a quick answer, Craig. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rarely there are /dev/md* files but no mdadm installed.