cmd/scollector: Added Azure Enterprise Agreement billing collector #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrandt
reviewed
Sep 20, 2016
| "bosun.org/opentsdb" | ||
| ) | ||
|
|
||
| var azureeabillingconfig = azureEABillingConfig{} |
There was a problem hiding this comment.
Also since it is used a a lot I would make it shorter. AzBillConf maybe .. or something better
kylebrandt
reviewed
Sep 20, 2016
| } | ||
|
|
||
| //Process the report list | ||
| err = processAzureEAReports(reports, &md) |
There was a problem hiding this comment.
if err ...; err != nil { sytax is better here
| thisMonth := baseTime.Format("2006-01") | ||
| lastMonth := time.Date(baseTime.Year(), baseTime.Month()-1, 1, 0, 0, 0, 0, time.UTC).Format("2006-01") | ||
| for _, r := range reports.AvailableMonths { | ||
| if thisMonth == r.Month || lastMonth == r.Month { |
There was a problem hiding this comment.
inverse condition to and continue so rest of code is not indented
| for _, r := range reports.AvailableMonths { | ||
| if thisMonth == r.Month || lastMonth == r.Month { | ||
| csv := azureeabillingconfig.AZEABillingConfig.GetMonthReportsCSV(r, azureeabilling.DownloadForStructs) | ||
| ioutil.WriteFile("c:\\temp\\ea-price.csv", []byte(csv.PriceSheetReport), 0755) |
| resourceString = fmt.Sprintf("%s-%s", strings.ToLower(p.ResourceGroup), resourceString) | ||
| } | ||
|
|
||
| resourceString, _ = opentsdb.Clean(resourceString) |
There was a problem hiding this comment.
ignoring err intentional, if so comment maybe
mhenderson-so
force-pushed
the
AzureADBilling
branch
from
569fa2b
to
5f46c13
Compare
|
The CSV library was very helpful - the standard library choked because the Azure CSV is formatted stupidly. This new library also allows the fields to potentially be re-ordered in the future, as it uses the header titles from the first line in the CSV to match them to their correct field in the struct tags when unmarshalling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Azure Enterprise Agreement billing collector into scollector.