cmd/scollector: enable SWbemServices worker for better WMI performance in Windows #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om win_service_main() This should prevent the service startup errors we were seeing indicating it was being unresponsive
…ent = true in toml file. Also add expvars when pprof is enabled.
…ngs. Use __no_name__ if c_dsc_status collector has any NULL ConfigurationName values
|
We didn't find any issues when testing, and this has been rolled out to all our Windows servers now. The default is still using the old code, you still have to specify UseSWbemServicesClient = true to use the new code. In the future we may change that to be the default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the WMI package to include the SWbemServices updates from StackExchange/wmi#23
I plan on testing this in our environment to make sure things are stable. Shouldn't cause any issues as everything is behind the UseSWbemServicesClient = true value in scollector.toml