cmd/tsdbrelay: Drain relay response so that connection is eligible for reuse. #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alienth
changed the title
|
The code has separate paths for bosun, relays, and metadata... do we need the same io.CopyN added to these: https:/alienth/bosun/blob/8b2135b1a85f9dd075ae222482ca3cbf0cd7cb8f/cmd/tsdbrelay/main.go#L253 https:/alienth/bosun/blob/8b2135b1a85f9dd075ae222482ca3cbf0cd7cb8f/cmd/tsdbrelay/main.go#L389 |
|
@gbrayut updated. |
gbrayut
approved these changes
Mar 13, 2017
|
Found some more cases in metadata/collect/etc where this occurs. This PR is superseded by #2036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsdbrelay is not reusing connections for its relay calls.
DefaultTransportwill not allow a connection to be reused unless the body has been read. This change will use the common pattern of reading 512 bytes from theresp.Bodyto try and ensure the connection is available for reuse. This is intentionally capped at 512 bytes to avoid waiting for cases of large responses.Some discussion on this if curious: https://groups.google.com/forum/#!search/golang$20json$20decode$20$20io.Copy/golang-nuts/4Rr8BYVKrAI/ZrJJFTNleekJ
Confirmed in testing that this addresses lack of connection reuse.
Partially addresses #2018.
@kylebrandt @captncraig @gbrayut