Fix math operations on results of aggr #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 11, 2018 10:31
Without this fix, math operations cause an error 'expr: opentsdb: bad tag: partner' to be returned
And refactor aggr tests to be table-driven
|
The tests are failing due to timeouts, doesn't seem to have any real issues. |
|
@kylebrandt how does this look to you? Would be nice to get the fix in 🙇 |
|
Looks like one of the test files just needs a gofmt |
|
Ah, was that the issue. Thanks, it's gofmt-ed now. |
|
Or not... maybe I need to upgrade to Go1.10 on this machine |
|
Alright, it's fixed now 👍 Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
aggrthat causes math operations on the resulting series to fail. It also adds tests for such cases, and refactors theaggrtests to be table-driven.Without this fix, math operations cause an error like expr: opentsdb: bad tag: color. The tests included here were failing before the fix with such an error.
CC @kylebrandt