Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use class instance to lock signing #462

Merged
merged 1 commit into from
Feb 13, 2015
Merged

Use class instance to lock signing #462

merged 1 commit into from
Feb 13, 2015

Commits on Feb 13, 2015

  1. Use class instance to lock signing 

    The `with threading.Lock()` statement does not actually lock
anything because we're creating a new lock each time.  The
fix here is to use an instance level lock.  We need to ensure that
the signer is not called in multiple threads as it is _not_ thread
safe.

This bug surfaces via S3 signature version 4 multithreaded uploads.
If you run "aws s3 cp/sync" in eu-central-1 or cn-north-1, you'll
see signature errors because the timestamp will be off be one or more
seconds.  Given this is a race condition, you'll need a fairly large
file (1GB to be safe) to see this issue.
    @jamesls
    jamesls committed Feb 13, 2015
    Configuration menu
    Copy the full SHA
    d8ced45 View commit details
    Browse the repository at this point in the history