-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cgi.FieldStorage not available in Python 3.13 #1438
Merged
Merged
Commits on Sep 5, 2024
-
Standard library cgi.FieldStorage was deprecated in Python 3.11 and removed in 3.13. We now have to ship our own multipart form data parser implementation, which is a port of the existing 'multipart' module. The new parser is used for all python versions, which may break backwards compatibility for certain edge cases and error scenarios. For a 'good' request there should be no difference, though. What changed: * Lax newline parsing (accepting \r or \n in place of \r\n) is a security risk and no longer implemented. Most modern browsers and client libraries follow the spec and should not have any issues producing valid multipart data. * Parsing errors are no longer silently ignored, but trigger an appropiate 400 error.
Configuration menu - View commit details
-
Copy full SHA for c3864de - Browse repository at this point
Copy the full SHA c3864deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fca684 - Browse repository at this point
Copy the full SHA 9fca684View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4cc5f9 - Browse repository at this point
Copy the full SHA f4cc5f9View commit details -
Those are integration tests, not unit tests and lead to flapping test results.
Configuration menu - View commit details
-
Copy full SHA for 1bf82df - Browse repository at this point
Copy the full SHA 1bf82dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b7306 - Browse repository at this point
Copy the full SHA f4b7306View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9116c7b - Browse repository at this point
Copy the full SHA 9116c7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 036627a - Browse repository at this point
Copy the full SHA 036627aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4b9e9f - Browse repository at this point
Copy the full SHA c4b9e9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0076a22 - Browse repository at this point
Copy the full SHA 0076a22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 291730e - Browse repository at this point
Copy the full SHA 291730eView commit details -
feat: BaseResponse.expires is now timezone aware (UTC)
This also prevents warnings for deprecated functions in the datetime module.
Configuration menu - View commit details
-
Copy full SHA for 8012a10 - Browse repository at this point
Copy the full SHA 8012a10View commit details -
Configuration menu - View commit details
-
Copy full SHA for d63f177 - Browse repository at this point
Copy the full SHA d63f177View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11d4d74 - Browse repository at this point
Copy the full SHA 11d4d74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ba4dbb - Browse repository at this point
Copy the full SHA 7ba4dbbView commit details -
docs: Removed python version requirement from readme.
This is better described in more detail in docs/index.rst
Configuration menu - View commit details
-
Copy full SHA for cd1acfc - Browse repository at this point
Copy the full SHA cd1acfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c26cdb - Browse repository at this point
Copy the full SHA 5c26cdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a92a74 - Browse repository at this point
Copy the full SHA 4a92a74View commit details -
Configuration menu - View commit details
-
Copy full SHA for c47d825 - Browse repository at this point
Copy the full SHA c47d825View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc7e8e0 - Browse repository at this point
Copy the full SHA bc7e8e0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.