Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsys-launcher: Script for naming ec2 instances #824

Merged

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented May 16, 2023

Issue number:

N/a - related to aws/aws-cdk#20133 where tags do not propegate down to the auto-scaling group (or the instances) for the node group.

Description of changes:

Adds a hack/name-instances.sh script that can be used to name instances in the testsys cluster "testsys-node".

Testing done:

❯ ./hack/name-instances.sh
i-0a6dd7241d2ed62cb tagged
i-0b45283a3d44adf78 tagged
i-016a20b12d38513c5 tagged
i-0c601c9c129c266ea tagged
i-08a76f38f8b9d7080 tagged

And instances are named correctly in the EC2 web console.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jpmcb jpmcb requested a review from jpculp May 16, 2023 02:14
@jpmcb jpmcb merged commit 910a912 into bottlerocket-os:develop May 17, 2023
@jpmcb jpmcb deleted the testsys-launcher-name-instances branch May 17, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants