Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] .mov playback support #66

Closed
dan0v opened this issue Apr 30, 2019 · 8 comments
Closed

[Feature] .mov playback support #66

dan0v opened this issue Apr 30, 2019 · 8 comments

Comments

@dan0v
Copy link

dan0v commented Apr 30, 2019

Is your feature request related to a problem? Please describe.
Many mobile phone cameras record videos in .mov format. Videos in this format are not even displayed in pigallery2, making some folders appear empty and being one of the greatest things holding me back from using pigallery2 as my main photo and video album service. If pigallery2 is to be a photo/video service like google photos for example, it should support commonly used formats.

Describe the solution you'd like
Provide video playback for .mov files (as many image and video formats as possible, really) to ensure that all photos and videos can be viewed as they should. If it is not possible to support full playback (I don't see why not for .mov), at least display these items in the interface instead of hiding them and provide the option to download the source files.

Describe alternatives you've considered (optional)
All .mov videos could be reencoded to mp4 using FFMPEG, but this is wasteful to both time and resources and will reduce source quality.

@dan0v dan0v changed the title Add .mov playback support [Feature] .mov playback support Apr 30, 2019
@bpatrik
Copy link
Owner

bpatrik commented May 1, 2019

Hi,

Unfortunately .mov files ar not supported by any browser. Only mp4, WebM and Ogg files are supported. More details here.. I cannot really do anything to fix it.

I would like to keep the app clean and simple. I feel that showing a file that the app cannot handle would cause confusion. The aim of the app is not a file browser but a photo gallery. (So not like google drive, but more like google photos) Therefore, at the moment, I would not like to list .mov files without full support.

I'm actually planning to make it possible to reconvert original photos/videos, so that I can support more extensions (like raw photos, .mov-s, etc..) and also my raspberry has difficulties streaming hi-res video files. So scaling down would be also good.
(Yes it would probably come with some quality loss, but you have the same issue if you upload to YouTube. The time should be ok. I'll build a task scheduling in the app, so you can schedule the conversions to like between 1am-6am)
See more about this at issue #50.

@civita
Copy link

civita commented May 10, 2019

I would like to have converting function with ffmpeg. Regarding the .mov files, I could play them with Safari browser with minor modifying to the existing codes.

Screen Shot 2019-05-11 at 4 28 54 AM

@bpatrik
Copy link
Owner

bpatrik commented May 13, 2019

Hi

It is relatively easy to add supported extensions to the app:
You need to add .mov to the folder reader, here:


And to the fronted here:

ffmpeg will create a thumbnail for you, so it will more or less work on the UI, but most likely the video wont play.

Unfortunately, there is no straightforward way now to automatically convert mov-s with ffmpeg .

Patrik

@civita
Copy link

civita commented May 13, 2019

Hi

It is relatively easy to add supported extensions to the app:
You need to add .mov to the folder reader, here:

And to the fronted here:

ffmpeg will create a thumbnail for you, so it will more or less work on the UI, but most likely the video wont play.

Unfortunately, there is no straightforward way now to automatically convert mov-s with ffmpeg .

Patrik

Thank you for providing the way to support .mov temporary. Since I am still using stable version (1.5.6) instead of the latest commit, the files I modified were:
backend/routes/GalleryRouter.js
backend/model/threading/DiskMangerWorker.js
common/entities/MediaDTO.js
Sounds like the same way as that you provided. With the Safari, I am able to play those .mov videos. :)

As for converting via ffmpeg, I am not sure how to do it simply and cleverly (I would like to make things simple as well!) Is it possible to provide "optimize" option to the .mov video like Plex does? Maybe it needs another database table to record all the converted files.

@bpatrik
Copy link
Owner

bpatrik commented May 13, 2019

Hi,

Started working on a task scheduler within the app (like crontab in Linux). Once it's ready it should be easy to do things like this.
Without that task scheduler, I dont see any easy way of converting the files.
Unfortunately I'm super-super busy with finishing my PHD, until that's done, I cant spend reasonable time on this project. sorry :/

@bobobo1618
Copy link
Contributor

Actually MOV and MP4 are essentially the same thing, just with a different file extension, so it should have the same support.

Where you might run into difficulty is if the device that created the file uses an unsupported codec or puts the MOOV atom at the end of the file.

@bpatrik
Copy link
Owner

bpatrik commented Dec 11, 2019

Hi,

The app now supports video transcoding with ffmpeg.
Therefore more video formats are supported.
See the full list here:

TranscodeNeed: {
Photos: <string[]>[],
Videos: [
'avi',
'mkv',
'mov',
'wmv',
'flv',
'mts',
'm2ts',
'mpg',
'3gp',
'm4v',
'mpeg',
'vob',
'divx',
'xvid',
'ts'
],

Please note that transcoding should be done manually in the settings. (or schedule it in advanced setting mode)

Best,
Patrik

@bpatrik bpatrik closed this as completed Dec 11, 2019
@2ge
Copy link

2ge commented Aug 17, 2022

just add 2 cents - there is no support MOV mentioned here: https://bpatrik.github.io/pigallery2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants