Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marshalling of raw_message field for empty messages #106

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

bradleyjkemp
Copy link
Owner

Always marshal the raw_message field. When marshaling (i.e. from grpc-dump), this field should always be written even if it is the empty string.

Fixes #105

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #106 into master will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   56.49%   56.40%   -0.10%     
==========================================
  Files          31       31              
  Lines        1177     1179       +2     
==========================================
  Hits          665      665              
- Misses        408      409       +1     
- Partials      104      105       +1     
Flag Coverage Δ
#integration 55.81% <0.00%> (-0.10%) ⬇️
#unit 18.67% <ø> (ø)
Impacted Files Coverage Δ
grpc-dump/dump/recorded_server_stream.go 82.50% <0.00%> (-4.35%) ⬇️
internal/dump.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8f888...d22cf1a. Read the comment docs.

@bradleyjkemp bradleyjkemp merged commit 33bc0ca into master Jun 30, 2020
@bradleyjkemp bradleyjkemp deleted the fix-emptymessage-marshalling branch June 30, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replaying requests without proto definitions
1 participant