Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create basic fuzzing harness for proto decoder #40

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

bradleyjkemp
Copy link
Owner

Adds a very basic fuzzing harness and fixes the most low-hanging errors in the decoder.

Also filed an upstream issue (jhump/protoreflect#233) for a proto parsing panic.

@bradleyjkemp bradleyjkemp merged commit 7ebe72c into master Jul 17, 2019
@bradleyjkemp bradleyjkemp deleted the unknown-message-fuzzing branch July 17, 2019 15:29
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #40 into master will decrease coverage by 0.73%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   58.81%   58.08%   -0.74%     
==========================================
  Files          29       30       +1     
  Lines        1066     1076      +10     
==========================================
- Hits          627      625       -2     
- Misses        342      352      +10     
- Partials       97       99       +2
Flag Coverage Δ
#integration 57.43% <0%> (-0.73%) ⬇️
#unit 15.84% <ø> (ø) ⬆️
Impacted Files Coverage Δ
internal/proto_decoder/fuzz.go 0% <0%> (ø)
internal/proto_decoder/unknown_message.go 53.62% <0%> (-4.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5558f...cd7f184. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #40 into master will decrease coverage by 0.73%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   58.81%   58.08%   -0.74%     
==========================================
  Files          29       30       +1     
  Lines        1066     1076      +10     
==========================================
- Hits          627      625       -2     
- Misses        342      352      +10     
- Partials       97       99       +2
Flag Coverage Δ
#integration 57.43% <0%> (-0.73%) ⬇️
#unit 15.84% <ø> (ø) ⬆️
Impacted Files Coverage Δ
internal/proto_decoder/fuzz.go 0% <0%> (ø)
internal/proto_decoder/unknown_message.go 53.62% <0%> (-4.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5558f...cd7f184. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant