Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/jhump/protoreflect from 1.5.0 to 1.6.0 #68

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps github.com/jhump/protoreflect from 1.5.0 to 1.6.0.

Release notes

Sourced from github.com/jhump/protoreflect's releases.

v1.6.0

This release contains bug fixes and new features/APIs.

"github.com/jhump/protoreflect/codec"

Changes/fixes:

  • The Buffer.EncodeFieldValue method will now use always packed encoding for repeated fields that are so configured. Previously, it only used packed encoding when the repeated field actually contained more than one value.
  • Encoding messages should now be compatible with message types generated by v2 of the protobuf module.

"github.com/jhump/protoreflect/desc/protoparse"

Additions:

  • The Parser struct has a new field named LookupImport. When set, if an imported file cannot be loaded via the parser's Accessor, this field will be invoked. Unlike Accessor, this field supplies an already parsed descriptor instead of protobuf source code to parse. This allows for parsed files' dependencies to provided in already-parsed descriptor form instead of having to re-parse said dependencies.

Changes/fixes:

  • The ResolveFilenames function has been modified so it should work as expected/documented on Windows platforms, not just platforms that use forward slash (/) as a path separator.
  • When parsing a file that contains an enum definition that has no values or a syntax error with one of the enum values, the parse operation would result in an "index out of range" panic. This has been fixed.
  • Support was added for groups that have field options. This is a lesser-known feature of groups (which is a technically deprecated feature of the proto2 syntax). In addition to message options inside the group body (which this package already supported), they can also contain field-style options. For example:
    message Foo {
      optional group Bar = 1 [(field.option) = "baz1"] {
          option (msg.option) = "baz2";
      }
    }
    
    This package now provides the same level of support for this as does protoc. Earlier versions of this package would have reported a syntax error at the opening bracket ([) of the field options.

"github.com/jhump/protoreflect/desc/protoprint"

Changes/fixes:

  • Support was added for groups that have field options. See the addition described above for the "protoparse" package for more details. Previously, a descriptor for a group that had both field and message options would result in only the message options being printed. Now the "protoprint" package also correctly prints field options for such descriptors.

"github.com/jhump/protoreflect/dynamic"

Changes/fixes:

  • When marshaling a dynamic message to the text format, if the message contained a string field value that contained a double-quote character ("), the resulting text output would be invalid and unparseable. This has been fixed.
  • The KnownTypeRegistry should now correctly identify well-known types when using generated types in v2 of the protobuf module.
  • When marshaling a dynamic message that contained a map field with a nil value (e.g. the value type is a message and the value stored in the map is a nil pointer), the operation would panic. Now it serializes that map entry with no value (e.g. the synthetic message representing the map entry will be serialized with only a key and omit the value field). This is how the protobuf module's proto package handles this scenario in generated messages with map fields.
Commits
  • 43f6903 fix comments for fields that start with a dot (proto3 fields with fully-quali...
  • 10815c2 allow nil values in map fields on dynamic messages (#287)
  • 1d00242 Support compiled file descriptors as imports in protoparse. (#284)
  • af6c2b7 fix unused assignments caught by staticcheck (#288)
  • 5374ad0 protoparse, protoprint: support group fields with options (#285)
  • 06c7559 Identify well-known types using proto.MessageName if the XXX_WellKnownType() ...
  • c0b9111 Fix text proto string field marshal issue. (#280)
  • 76f37dc fix panic in protoparse (#272)
  • c47b58f Use packed encoding if there are any values, not just more than 1 (#270)
  • 9d66a93 fixup path separators in protoparse.ResolveFilenames so it works correctly on...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [github.com/jhump/protoreflect](https:/jhump/protoreflect) from 1.5.0 to 1.6.0.
- [Release notes](https:/jhump/protoreflect/releases)
- [Commits](jhump/protoreflect@v1.5.0...v1.6.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   56.81%   56.81%           
=======================================
  Files          31       31           
  Lines        1167     1167           
=======================================
  Hits          663      663           
  Misses        400      400           
  Partials      104      104
Flag Coverage Δ
#integration 56.21% <ø> (ø) ⬆️
#unit 19.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1432a5...1e49531. Read the comment docs.

@bradleyjkemp bradleyjkemp merged commit e184bc7 into master Dec 18, 2019
@bradleyjkemp bradleyjkemp deleted the dependabot/go_modules/github.com/jhump/protoreflect-1.6.0 branch December 18, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant