Refactoring structures/.. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamltyson
approved these changes
May 28, 2020
vigji
approved these changes
May 28, 2020
| @@ -389,3 +396,93 @@ def path_to_list(path): | |||
| return list(path) | |||
|
|
|||
| return [int(stid) for stid in path.split("/") if stid != ""] | |||
|
|
|||
| def print_structures(self, to_file=False, save_filepath=None): | |||
There was a problem hiding this comment.
I think this is a convenient function and I see the point of having it here; I am a splitting maniac and I would keep it as a separate function then used here, put it's a matter of taste - as long as this class does not get too long
There was a problem hiding this comment.
I am a splitting maniac
You really are :P
I prefer keeping the number of files / classes low at the cost of slightly longer classes. Especially for stuff like this which is behind the scenes and we won't have to edit it often if at all.
I guess we can find a compromise? :)
There was a problem hiding this comment.
I would agree on a maximum number of lines per class 😄 500?
willGraham01
pushed a commit
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
structures/simple_tree.pyandstructures/structure_tree.py:print_structuresandprint_structures_treefromcore.Atlastostructures_structures_tree.pyto keepAtlascleaner.