Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on warnings raised in tests #140

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Feb 21, 2023

This PR catches any warnings that are emitted by tests, and errors on them. This is generally good practice, to make sure the code isn't emitting any warnings, or if it is that they are intended.

There were also some warnings I had to fix. Hopefully the fixes look right!

@dstansby dstansby force-pushed the filterwarnings branch 3 times, most recently from f19a887 to c346670 Compare February 24, 2023 09:20
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 85.26% // Head: 85.26% // No change to project coverage 👍

Coverage data is based on head (c346670) compared to base (4aaadba).
Patch has no changes to coverable lines.

❗ Current head c346670 differs from pull request most recent head 301e70a. Consider uploading reports for the commit 301e70a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files          11       11           
  Lines         536      536           
=======================================
  Hits          457      457           
  Misses         79       79           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dstansby dstansby marked this pull request as ready for review February 27, 2023 15:52
@dstansby dstansby requested a review from a team February 27, 2023 15:53
@adamltyson adamltyson merged commit 00f2de7 into brainglobe:main Mar 2, 2023
@dstansby dstansby deleted the filterwarnings branch March 6, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants