Fix download progress bar #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
pre-commit.ci run |
…s no text matching the regex.
|
Looks good, thanks @IgorTatarnikov. Would it be possible to add a couple of tests for the exception handling to keep the test coverage up? |
adamltyson
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Description
What is this PR
Why is this PR needed?
Fix the bug with the progress bar when the content-length header is missing.
What does this PR do?
Creates a new function that's called if the content-length header is missing to parse the size from the equivalent 'src' page on GIN.
References
closes #121
closes #177
How has this PR been tested?
The PR was tested locally by downloading several atlases. Existing functionality was checked by running tests. New tests were added to ensure the correct sizes are returned by the new function.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: