Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Axolotl Pooch hash #347

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Conversation

saimaabdus19
Copy link
Contributor

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Axolotl file download with pooch is missing hashes.

What does this PR do?

Add the hashes of the downloaded files.

References

Closes #342

How has this PR been tested?

Tested and visualized manually in the computer.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No, will be updated after the completion of the atlas.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @saimaabdus19!
We'll fix the orientation separately, so I'll make changes so this PR does not affect orientation.

@alessandrofelder alessandrofelder merged commit 33f9205 into brainglobe:main Aug 6, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add known hashes for pooch to axolotl atlas
3 participants