Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of spurious pixels #349

Merged

Conversation

saimaabdus19
Copy link
Contributor

@saimaabdus19 saimaabdus19 commented Aug 8, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

To remove any unwanted spurious pixels from the axolotl atlas.

What does this PR do?

Remove spurious pixels from the axolotl atlas using scikit-image,

References

#344

How has this PR been tested?

Visually observed via Napari.

Is this a breaking change?

No, it does not.

Does this PR require an update to the documentation?

No, it does not.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @saimaabdus19 !
This works as expected - I think it can be simplified: you can replace the for loop in one big step :)

@alessandrofelder alessandrofelder merged commit 71f6d5b into brainglobe:main Aug 9, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants