fixed bug where progress bar didn't update properly #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the progress bar bug described here #334
It was because refresh was true which means the progress bar had to update on every single chunk. On a fast internet connection this was way too frequently. By setting refresh to False (it's default value) the progress bar chunks its updates and updates at a sensible frequency. This solves the update issue on my machine.
What is this PR
References
#334
How has this PR been tested?
It's a very minor change however I have downloaded multiple atlases and it works.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist:
(it is changing one argument im not sure i need to run the pre-commit formatting but i can)