Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for brainmapper sub-module #49

Closed
K-Meech opened this issue Mar 13, 2024 · 3 comments · Fixed by #52
Closed

Create tests for brainmapper sub-module #49

K-Meech opened this issue Mar 13, 2024 · 3 comments · Fixed by #52
Assignees

Comments

@K-Meech
Copy link
Contributor

K-Meech commented Mar 13, 2024

More tests need to be added for the brainmapper sub-module - aiming at >90% coverage.

@K-Meech K-Meech self-assigned this Mar 13, 2024
@K-Meech
Copy link
Contributor Author

K-Meech commented Mar 13, 2024

I'm looking into writing tests for the summarise_points_by_atlas_region function. This requires a corresponding BrainGlobeAtlas object, but I'm not sure which one corresponds to the test volume.csv file.

Any ideas? @alessandrofelder

@alessandrofelder
Copy link
Member

My guess is that's it's an Allen one (I know it's definitely a mouse thanks to @niksirbi ) - I would try using BrainGlobeAtlas("allen_mouse_100um") in the tests (because it's the lowest res one) and see how far you get?

@adamltyson may know more exactly how this data was generated?

@adamltyson
Copy link
Member

I assume it's allen_mouse_something. No idea which, but to some level of precision, it shouldn't matter. The volumes are in mm^3 and that's the same across all resolutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants