add tests for transforming to atlas space function #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
More tests are always better - just wondering if we can use parameterisation to combine the two tests into one? Right now there's a lot of repeated code in both - the only difference being the values of mock_deformation_field, downsampled_points, and the values the assertions check against at the end
|
Good point. |
willGraham01
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Improves test coverage.
What does this PR do?
Adds two basic tests for
brainmapper.brainreg.transform.transform_points_from_downsampled_to_atlas_space()References
This was part of debugging what was going on brainglobe-workflows/83 (but turned out to be unrelated)
How has this PR been tested?
This PR just adds tests, which pass, as do all existing tests.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: