Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minisblack photometric to tiff writing #46

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Add minisblack photometric to tiff writing #46

merged 2 commits into from
Mar 11, 2024

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Mar 11, 2024

Closes #45

Description

Adds photometric="minisblack" to tiff writing. This ensures that no images are wrongly detected and written as RGB.

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

@K-Meech K-Meech requested a review from a team March 11, 2024 14:12
alessandrofelder
alessandrofelder approved these changes Mar 11, 2024
View reviewed changes
brainglobe_utils/image_io/save.py Outdated Show resolved Hide resolved
@K-Meech @alessandrofelder
Add default to photometric docstring
934bd03 
Co-authored-by: Alessandro Felder <[email protected]>
@K-Meech K-Meech merged commit 7aad98f into main Mar 11, 2024
10 checks passed
@K-Meech K-Meech deleted the tifffile_photometric branch March 11, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrofelder alessandrofelder alessandrofelder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writing 3D tiffs throws deprecation warning
2 participants
@K-Meech @alessandrofelder