Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axolotl blog #238

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Axolotl blog #238

merged 7 commits into from
Aug 13, 2024

Conversation

saimaabdus19
Copy link
Contributor

@saimaabdus19 saimaabdus19 commented Aug 9, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

To add a blog about the axolotl.

How has this PR been tested?

Visual inspection of local build.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • [ \ ] Tests have been added to cover all new functionality (unit & integration)
  • [ \ ] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder requested a review from a team August 12, 2024 16:04
@adamltyson
Copy link
Member

Is it worth adding the atlas to the list in this PR too?

Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally ok, but as discussed on slack, I think we should discuss here that the atlas contains lots of non-brain tissue, and so is may be for visualisation only.

docs/source/blog/axolotl-atlas-added.md Outdated Show resolved Hide resolved
docs/source/blog/axolotl-atlas-added.md Outdated Show resolved Hide resolved
docs/source/blog/axolotl-atlas-added.md Outdated Show resolved Hide resolved
docs/source/blog/axolotl-atlas-added.md Outdated Show resolved Hide resolved
@adamltyson
Copy link
Member

I softened the language slightly, I didn't want to stop anyone trying to register data to this atlas just because I decided it wouldn't work well!

@adamltyson adamltyson merged commit 0c9d5b5 into brainglobe:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants