-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide DDG option from Private/Tor new tab if default search is overridden #1632
Labels
feature/private-browsing
feature/search
needs-text-change
This change requires some careful wording.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
Milestone
Comments
cc: @mkarolin who implemented the original logic for search engine defaults with brave/brave-core#516 |
bsclifton
added
needs-text-change
This change requires some careful wording.
feature/search
labels
Oct 16, 2018
18 tasks
Verification Passed on
Verification Passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/private-browsing
feature/search
needs-text-change
This change requires some careful wording.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
Test plan
Description
Related to #1607
The above issue has a fix implemented with brave/brave-core#654
However, this is checking
navigator.language
in the JavaScript code instead of:OR
And exposing this to the webUI code. This could potentially be set as a new profile preference in
src/components/search_engines/template_url_prepopulate_data.cc
; for example:prefs->SetInteger(prefs::kSearchOverridden, 1);
The new tab pages would then consider this value. If set to 1 or True, they would not display the DDG panel (matching behavior in
browser-laptop
)The text was updated successfully, but these errors were encountered: