Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification button on Brave Rewards Panel says MISSING:OK #1633

Closed
LaurenWags opened this issue Oct 17, 2018 · 1 comment · Fixed by brave/brave-core#661
Closed

Notification button on Brave Rewards Panel says MISSING:OK #1633

LaurenWags opened this issue Oct 17, 2018 · 1 comment · Fixed by brave/brave-core#661

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Oct 17, 2018

Description

Button on notification on Brave Rewards Panel says 'MISSING:OK'.

Steps to Reproduce

  1. Enable Rewards on 0.55.16.
  2. Click on BAT logo.
  3. Notification is displayed.

Actual result:

Button text:
screen shot 2018-10-16 at 7 58 00 pm

Expected result:

Button should not indicate missing text.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? n/a - code not in those builds yet
  • Does it reproduce on browser-laptop? n/a

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @NejcZdovc @jenn-rhim

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 17, 2018

Verified passed with

Brave 0.57.1 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

screen shot 2018-10-17 at 6 28 12 pm

Went through verification using the following build under Win 10 x64 - PASSED

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

capture

Verification Passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants