Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar options in settings UI doesn't have bottom border #21099

Closed
simonhong opened this issue Feb 15, 2022 · 3 comments · Fixed by brave/brave-core#12258
Closed

sidebar options in settings UI doesn't have bottom border #21099

simonhong opened this issue Feb 15, 2022 · 3 comments · Fixed by brave/brave-core#12258

Comments

@simonhong
Copy link
Member

simonhong commented Feb 15, 2022

As captured below, sidebar options has redundant top border and bottom border is missed.
It should have bottom border only.
Screen Shot 2022-02-15 at 2 03 21 PM

STR

  1. Enable sidebar flags
  2. Load brave://settings/?search=sidebar
  3. Check Sidebar options border
@stephendonner
Copy link

Verified PASSED using

Brave 1.37.50 Chromium: 98.0.4758.87 (Official Build) nightly (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Windows 10 Version 21H2 (Build 19044.1526)

Steps:

  1. install 1.37.50
  2. launch Brave
  3. enabled Sidebar via brave://flags
  4. clicked to Relaunch
  5. loaded brave://settings/appearance
  6. confirmed the Settings UI now has the correct top/bottom border for Show Sidebar
pre-fix post-fix
21099-1 21099-2

@btlechowski
Copy link

Verification passed on

Brave 1.37.83 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS

image
image

@stephendonner
Copy link

Verified PASSED using

Brave 1.37.91 Chromium: 99.0.4844.51 (Official Build) beta (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 12.3 (Build 21E230)
dark light
Screen Shot 2022-03-14 at 10 58 42 PM Screen Shot 2022-03-14 at 10 59 13 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment