Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet networks suggestion UI #23628

Closed
supermassive opened this issue Jun 23, 2022 · 1 comment · Fixed by brave/brave-core#14067
Closed

Wallet networks suggestion UI #23628

supermassive opened this issue Jun 23, 2022 · 1 comment · Fixed by brave/brave-core#14067
Assignees
@supermassive
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.43.x - Release

Comments

@supermassive
Copy link

After #14574 need to implement UI in brave://settings/wallet/networks which helps user autofill custom networks.
@supermassive supermassive added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jun 23, 2022
@yrliou yrliou added the front-end-change This task is a front end task and doesn't need any C++ changes label Jun 23, 2022
@HEagle18 HEagle18 added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 28, 2022
@supermassive supermassive mentioned this issue Jul 7, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 12, 2022
@supermassive supermassive mentioned this issue Jul 13, 2022
Closed
7 tasks
@supermassive supermassive modified the milestones: 1.42.x - Release, 1.41.x - Release #4, 1.43.x - Beta Jul 29, 2022
@supermassive supermassive mentioned this issue Jul 29, 2022
Closed
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.43.79 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Linux
  • Verified steps from brave/brave-core#14067
  • Verified able to search for known networks in add custom network screen
  • Verified able to add a new network via search pre-defined network list
23628-Linux.mp4

Verification passed on

Brave 1.43.79 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from brave/brave-core#14067
  • Verified able to search for known networks in add custom network screen
  • Verified able to add a new network via search pre-defined network list
23628-Windows.mp4

Verification passed on

Brave 1.43.79 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#14067
  • Verified able to search for known networks in add custom network screen
  • Verified able to add a new network via search pre-defined network list
23628.mov

@LaurenWags LaurenWags mentioned this issue Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Search Wallet Networks brave/brave-core
5 participants
@supermassive @yrliou @HEagle18 @srirambv @brave-builds