Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move top sites widget to the top when stats are hidden regardless of clock #7855

Closed
wooque opened this issue Jan 21, 2020 · 2 comments · Fixed by brave/brave-core#4075
Closed

Comments

@wooque
Copy link

wooque commented Jan 21, 2020

Description

When stats are hidden, top sites don't move to the top unless clock widget is hidden also.

Steps to Reproduce

  1. Open new tab page
  2. Hide Brave stats

Actual result:

2020-01-22-002445_1919x412_scrot

Expected result:

Top sites are on top even with clock widget shown, something like in pic related
2020-01-22-002552_1919x253_scrot

Reproduces how often:

Always reproduced

Brave version (brave://version info)

Brave 1.2.43 Chromium: 79.0.3945.130 (Official Build) unknown (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Linux
JavaScript V8 7.9.317.33
Flash (Disabled)
User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36
Command Line /usr/lib/brave-bin/brave --enable-features=OverlayScrollbar --disable-features=TabHoverCards --disable-smooth-scrolling --enable-gpu-rasterization --ignore-gpu-blacklist --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --enable-oop-rasterization=Enabled --sync-url=https://no-thanks.invalid --enable-features=PasswordImport,WebUIDarkMode,SimplifyHttpsIndicator,OverlayScrollbar --disable-features=LookalikeUrlNavigationSuggestionsUI,NotificationTriggers,AutofillServerCommunication,UnifiedConsent,WebXrGamepadModule,AllowPopupsDuringPageUnload,SyncUSSBookmarks,WebXR,AudioServiceOutOfProcess,SmsReceiver,TabHoverCards --flag-switches-begin --disable-oop-rasterization --flag-switches-end --disable-webrtc-apm-in-audio-service
Executable Path /usr/lib/brave-bin/brave
Profile Path /home/vuk/.config/BraveSoftware/Brave-Browser/Default

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? /
  • Does the issue resolve itself when disabling Brave Rewards? /
  • Is the issue reproducible on the latest version of Chrome? /

Miscellaneous Information:

@bsclifton
Copy link
Member

bsclifton commented Jan 23, 2020

cc: @cezaraugusto @petemill

@LaurenWags
Copy link
Member

LaurenWags commented Feb 4, 2020

Verified passed with

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)
  • Reproduced the issue using 1.2.43:

Screen Shot 2020-02-04 at 3 18 47 PM

  • Verified STR from description:

Screen Shot 2020-02-04 at 3 19 27 PM

  • Verified top sites move back down when stats are re-enabled

  • Verified for clean and upgrade profiles

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified top sites move back down when stats are re-enabled
  • Verified for clean and upgrade profiles

Verification passed on

Brave 1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision 583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS Ubuntu 18.04 LTS
  • Verified top sites move back down when stats are re-enabled
  • Verified for clean and upgrade profile
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment